This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Replace link tags with site variables #6795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-matthews
added
Internal Dev
dshevtsov
approved these changes
Mar 4, 2020
|
running tests |
|
Hi @jeff-matthews, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) replaces the Jekyll
linktag with the{{ site.baseurl }}variable.We should not use the
linktag in the devdocs project because it doesn't support the variables we use, such as{{ page.baseurl }}.Furthermore, using the
linktag is incompatible with our "fast local build" workflow using the_config.local.ymlfile.The tag forces jekyll to validate internal links during build time. If you're building only certain directories specified in the
_config.local.ymlfile, this could create problems because it forces you to build directories you wouldn't otherwise need just to prevent Jekyll from failing on links to directories you're excluding.Affected DevDocs pages
Topics in the Marketplace and Compliance sections.