Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#6774: Input UI Component Example incorrect #6784

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Mar 4, 2020

Purpose of this pull request

This pull request (PR) provides a fix for #6774.

Affected DevDocs pages

  • ...

Links to Magento source code

  • ...

Thank you!

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@jeff-matthews
Copy link
Contributor

You're a hero @atwixfirster! Thank you for demonstrating the power of the Magento Community.

@atwixfirster
Copy link
Contributor Author

You're a hero @atwixfirster! Thank you for demonstrating the power of the Magento Community.

With my pleasure , @jeff-matthews :)

Thank you 👍

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the field is the correct definition of a form element in XML declaration of UI component. The following configuration can be checked as an example.

https://github.com/magento/magento2/blob/2.3/app/code/Magento/Catalog/view/adminhtml/ui_component/design_config_form.xml#L39

@rogyar rogyar added the Technical Updates to the code or processes that alter the technical content of the doc label Mar 4, 2020
@dobooth
Copy link
Contributor

dobooth commented Mar 5, 2020

running tests

@dobooth dobooth merged commit 8fb49cf into magento:master Mar 5, 2020
@ghost
Copy link

ghost commented Mar 5, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants