This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Add missing configuration #6770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Ziffity
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
|
Hi @anandhan-ziffity. Thank you for your collaboration. Could I kindly ask you to provide more information in the PR description about the purpose of the current PR next time, please? Particularly, describe the fact why do we need this change. Thank you! |
rogyar
approved these changes
Mar 3, 2020
dobooth
added
2.3.x
dobooth
approved these changes
Mar 6, 2020
|
Hi @anandhan-ziffity, thank you for your contribution! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Add missing configuration
This pull request (PR) adds a missing attribute to the sample code.
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.2/javascript-dev-guide/javascript/requirejs.html