This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Updating output attribute in place order mutation output object #6753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Ziffity
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
Feb 29, 2020
| @@ -73,8 +73,8 @@ Attribute | Data Type | Description | |||
|
|
|||
| Attribute | Data Type | Description | |||
| --- | --- | --- | |||
| `order_id` String | The unique ID that identifies the order | |||
| `order_number` String | The unique ID that identifies the order | |||
| `order_id` |String! | Deprecated.Use order_number instead.The unique ID that identifies the order | |||
There was a problem hiding this comment.
Hi @VinothKumar361. Please, make sure that the number of whitespaces is proper for both lines
Suggested change
| `order_id` |String! | Deprecated.Use order_number instead.The unique ID that identifies the order | |
| `order_id` | String! | Deprecated. Use order_number instead. The unique ID that identifies the order |
| `order_id` String | The unique ID that identifies the order | ||
| `order_number` String | The unique ID that identifies the order | ||
| `order_id` |String! | Deprecated.Use order_number instead.The unique ID that identifies the order | ||
| `order_number`| String | The unique ID that identifies the order |
There was a problem hiding this comment.
Suggested change
| `order_number`| String | The unique ID that identifies the order | |
| `order_number` | String | The unique ID that identifies the order |
|
Hi @rogyar , changes has been done. |
rogyar
approved these changes
Mar 1, 2020
keharper
approved these changes
Mar 2, 2020
keharper
added
2.3.x
|
Hi @VinothKumar361, thank you for your contribution! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) updates order_id which is deprecated in outupt object of place order mutation in graphql
Affected DevDocs pages
Links to Magento source code