Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Port content updates after doc site maintenance #4914

Merged
merged 8 commits into from
Jul 10, 2019

Conversation

@meker12 meker12 self-assigned this Jul 9, 2019
@meker12 meker12 requested a review from dshevtsov July 9, 2019 21:44
@meker12 meker12 changed the title Mae fix v2.3 routes contenteker12 patch 1 mae -restore-route-doc-updates Jul 9, 2019
@dshevtsov
Copy link
Collaborator

@meker12 please change a title of the PR to a short readable summary of the committed changes.

Copy link
Collaborator

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear from the description what issue the PR is intended to resolve.
Symlinked content cannot have any updates, because symlinks by nature cannot keep any content different from the file they were linked to. So, after the symlinks were replaced with real files, the actual content didn't change.

@meker12 meker12 added 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Jul 9, 2019
@meker12 meker12 changed the base branch from master to small_changes July 9, 2019 22:05
@meker12 meker12 marked this pull request as ready for review July 9, 2019 22:06
@meker12 meker12 changed the title mae -restore-route-doc-updates Port content updates after doc site maintenance Jul 9, 2019
@meker12 meker12 changed the base branch from small_changes to master July 9, 2019 22:29
@meker12
Copy link
Contributor Author

meker12 commented Jul 9, 2019

running tests

@meker12 meker12 merged commit 7419370 into master Jul 10, 2019
@ghost
Copy link

ghost commented Jul 10, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 deleted the mae-fix-v2.3-routes-contenteker12-patch-1 branch July 18, 2019 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants