Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add code samples for alert widget and add information about modalClass option #4731

Merged
merged 4 commits into from
Jun 19, 2019

Conversation

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Jun 12, 2019
@rogyar rogyar added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Jun 12, 2019
Serhiy Zhovnir added 2 commits June 19, 2019 10:20
# Conflicts:
#	guides/v2.1/javascript-dev-guide/widgets/widget_alert.md
@serhiyzhovnir
Copy link
Contributor Author

Hi @erikmarr
The required changes were added.
Can you, please, check it again?
Thank you!

@erikmarr
Copy link
Contributor

running tests

@erikmarr erikmarr merged commit 922ca0c into magento:master Jun 19, 2019
@ghost
Copy link

ghost commented Jun 19, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@erikmarr
Copy link
Contributor

Thanks @serhiyzhovnir!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants