This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Correct vendor name #4567
Merged
Correct vendor name #4567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proper vendor name for the elasticsearch module is elasticsearch, not elastic.
|
@billygilbert thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
An admin must run tests on this PR before it can be merged. |
|
From a technical standpoint, this PR is correct. Here is a link with an example from the codebase https://github.com/magento/magento2/blob/211dd25c73bb2539c3c064374d9d5649f253fd14/composer.json#L38 |
rogyar
added
Technical
rogyar
approved these changes
May 21, 2019
keharper
added
the
Internal Dev
|
Hi @billygilbert, thank you for your contribution! |
|
Thanks @billygilbert |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
The proper vendor name for the elasticsearch module is elasticsearch, not elastic.
Affected DevDocs pages