Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

It is easy to Locate styles and css path with grunt tool #4480

Merged
merged 4 commits into from
May 20, 2019

Conversation

abrarpathan19
Copy link
Contributor

Purpose of this pull request

This pull request (PR) easy to Locate styles and css path with grunt tool.

Affected DevDocs pages

Links to Magento source code

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

Copy link
Contributor

@dobooth dobooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it easy to use Grunt to find styles? Need to have a period instead of a comma at the start of your change.

@abrarpathan19
Copy link
Contributor Author

abrarpathan19 commented May 14, 2019

How is it easy to use Grunt to find styles? Need to have a period instead of a comma at the start of your change.

Tt easy to use Grunt to find styles because when running the grunt command we can see the specific CSS path and line number as well. for example http://prntscr.com/nodp4u

Also, I have updated the suggested change. please review.

@dobooth dobooth changed the base branch from master to small_changes May 20, 2019 20:01
@dobooth dobooth merged commit 85b4529 into magento:small_changes May 20, 2019
@ghost
Copy link

ghost commented May 20, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth added 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels May 20, 2019
@dobooth dobooth mentioned this pull request May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Partner: Krish TechnoLabs partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants