This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update xml-instructions.md to remove unnecessary html tag #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An admin must run tests on this PR before it can be merged. |
meker12
suggested changes
Mar 5, 2019
There was a problem hiding this comment.
Similar changes needed for version 2.1 of the file https://devdocs.magento.com/guides/v2.1/frontend-dev-guide/layouts/xml-instructions.html file.
…leading tag from "remove" attribute for v2.1 guide
|
@meker12 Code review changes are done, kindly review, thanks. |
meker12
approved these changes
Mar 5, 2019
|
running tests |
|
Hi @hgajjar, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
Removed extra HTML tag which is being displayed in browser, and fixed a misleading xml tag for an xml attribute.
Additional information
List all affected URLs
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/xml-instructions.html
https://devdocs.magento.com/guides/v2.2/frontend-dev-guide/layouts/xml-instructions.html
https://devdocs.magento.com/guides/v2.1/frontend-dev-guide/layouts/xml-instructions.html
whatsnew
Corrected the syntax for the
removeattribute used with the<referenceBlock>and<referenceContainerlayout instructions.