Skip to content

Frontend fixes - table text column not ediatble, state control exposed methods #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024
Merged

Frontend fixes - table text column not ediatble, state control exposed methods #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6009284
fix stringExposingStateControl exposed methods
raheeliftikhar5 May 14, 2024
4db4036
fixed empty table text column isn't editabled
raheeliftikhar5 May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/packages/lowcoder/src/components/table/EditableCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ export function EditableCell<T extends JSONValue>(props: EditableCellProps<T>) {
>
{status === "toSave" && !isEditing && <EditableChip />}
<div
style={{minHeight: '24px'}}
onDoubleClick={enterEditFn}
>
{normalView}
Expand Down
1 change: 0 additions & 1 deletion client/packages/lowcoder/src/comps/comps/tabs/tabbedContainerComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ const getStyle = (
headerStyle: ContainerHeaderStyleType,
bodyStyle: ContainerBodyStyleType,
) => {
console.log("🚀 ~ style:", style)
return css`
&.ant-tabs {
overflow: hidden;
Expand Down
6 changes: 3 additions & 3 deletions client/packages/lowcoder/src/comps/controls/codeStateControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ function stateControlMethodExposing<T extends ExposeMethodCompConstructor<Abstra
return withMethodExposingBase(VariantComp, [
{
method: {
name: trans("eventHandler.set") + _.upperFirst(param.name),
name: "set" + _.upperFirst(param.name),
description: trans("exportMethod.setDesc", { property: param.name }),
params: [param],
},
Expand All @@ -222,7 +222,7 @@ function stateControlMethodExposing<T extends ExposeMethodCompConstructor<Abstra
},
{
method: {
name: trans("eventHandler.clear") + _.upperFirst(param.name),
name: "clear" + _.upperFirst(param.name),
description: trans("exportMethod.clearDesc", { property: param.name }),
params: [],
},
Expand All @@ -233,7 +233,7 @@ function stateControlMethodExposing<T extends ExposeMethodCompConstructor<Abstra
},
{
method: {
name: trans("eventHandler.reset") + _.upperFirst(param.name),
name: "reset" + _.upperFirst(param.name),
description: trans("exportMethod.resetDesc", { property: param.name }),
params: [],
},
Expand Down
Loading