Skip to content

Agora Meetings in lowcoder-comps - production ready #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 28, 2024

Conversation

FalkWolsky
Copy link
Contributor

Proposed changes

As the Agora SDK Packages are huge, we moved the whole solution to lowcoder-comps. The effect is that when you do not use Agora Meetings in your App, the SDKs won't load and so speed up the app loading. Also, @freddysundowner fixed a number of bugs regarding the Agora Meeting Implementation, and we can say now it is production ready.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for lowcoder-test failed.

Name Link
🔨 Latest commit d6cbbaf
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/662e31f52ee83a0008a3fcfa

@FalkWolsky FalkWolsky merged commit 1eb2856 into dev Apr 28, 2024
2 of 7 checks passed
@FalkWolsky FalkWolsky deleted the condition-load-agora branch April 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants