Skip to content

feat(client): class and data-test property to each component to enable advanced styling and e2e testing #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hulutter
Copy link

Proposed changes

Add configurable class and data-testid properties to all components in a dedicated component section.
This enables advanced styling use cases as well as e2e test automation.
The changes are incorporated in a way that additional component attributes can be added in the future.

Types of changes

What types of changes does your code introduce to Lowcoder?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

hulutter added 2 commits April 24, 2024 09:22
Copy link

netlify bot commented Apr 24, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9c8b97b

@hulutter hulutter marked this pull request as ready for review April 24, 2024 09:09
@FalkWolsky FalkWolsky changed the base branch from dev to individualClass April 24, 2024 09:51
@FalkWolsky FalkWolsky merged commit 753b59a into lowcoder-org:individualClass Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants