Skip to content

docker all-in-one image updates for Debian Bookworm base image #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

sseide
Copy link
Contributor

@sseide sseide commented Apr 23, 2024

Proposed changes

The currently used base image for the All-In-One image is based on Debian 12 Bookworm.
Some parts of the additional software installation are not adapted to the current distro and use packages build for other versions.

Another update is for security reasons: disable the supervisord network server that was enabled WITHOUT any authentication. The port was not officially exported within the Dockerfile and not mentioned at all in the documentation. Therefor not used.
As it is not needed to run (supervisorctl uses unix socket) it should be disabled for security reasons.

People to want to used the network access to supervisord had to explicit export port by themself with current image too and do know what they do - they will probably provide a custom supervisord config with auth by themself than also.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Remark: current state of "dev" branch do not build. This is not due to this PR, current "dev" is broken because yarn build fails with a not working test case (FAIL src/__test__/allComp.test.tsx).
This PR is completly unrelated to the failing test.

Copy link

netlify bot commented Apr 23, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit de2af71

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this valuable contribution!! We like it a lot.

@FalkWolsky FalkWolsky merged commit ded99fd into lowcoder-org:dev Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants