Skip to content

Allow pinning the code editor popup #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snowe2010
Copy link
Contributor

Proposed changes

The code editor popup now has a button to allow 'pinning' the editor to
the screen so that it does not disappear when you click outside of it.
This currently only works if the right panel stays open, so that means
you cannot click inside of the app window unless it's on your component.
Anything else will dismiss the right panel and the popup will disappear,
even if pinned.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Screenshot 2024-04-07 183504
Screenshot 2024-04-07 183557

The code editor popup now has a button to allow 'pinning' the editor to
the screen so that it does not disappear when you click outside of it.
This currently only works if the right panel stays open, so that means
you cannot click inside of the app window unless it's on your component.
Anything else will dismiss the right panel and the popup will disappear,
even if pinned.
Copy link

netlify bot commented Apr 8, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ded0c8b

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool and handy feature! Thank you very much!!

@FalkWolsky FalkWolsky merged commit 1df9973 into lowcoder-org:dev Apr 8, 2024
@snowe2010 snowe2010 deleted the allow-pinning-code-editor-popup branch April 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants