-
Notifications
You must be signed in to change notification settings - Fork 245
Add AWS AppConfig API Data Source #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add an AWS AppConfig API Data Source with several query options. Not all are implemented, but most of the main ones are.
certain apis provide a list of valid options, but null is also an option.. this essentially adds that null option so that we can call without providing a parameter. this is useful in github's api
👷 Deploy request for lowcoder-cloud pending review.Visit the deploys page to approve it
|
👷 Deploy request for lowcoder-test pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we ask you to prepare a small Postman Collection and add it instead of the api-examples? That would allow us to create soon a Lowcoder Workspace on Postman and collect all such API calls as demonstration. We think it would be more visible...
I'm not actually sure I can, Postman refuses to let me sign in anymore. It's been broken since they changed from being a free service to mostly paid. :/ My team at work entirely switched to using the HTTP file standard which means you can easily store and run your collections directly from your IDE rather than in a proprietary software. It's worked out quite well. But yeah, it's definitely not as popular as Postman though :( |
Yeah I'm unable to sign in, so I can't save any requests so I can't export anything :(. I can remove the file if you don't want http files in the codebase, though I think they're much more open source friendly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We love your contribution a lot, so we merge it now.
The api-examples file we may exchange with a Postman Collection later. As for now, we think you are right so we take it into the change. Thank you very much for your valuable contribution!!
Proposed changes
Add an AWS AppConfig API Data Source
Types of changes
Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.
We need an AppConfig data source, and this was a simple addition alongside the lambda, dynamo, and athena plugins.
are implemented, but most of the main ones are.