Skip to content

Drawer Close Button Left or Right #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Drawer Close Button Left or Right #716

merged 2 commits into from
Feb 26, 2024

Conversation

sudoischenny
Copy link
Contributor

Proposed changes

Adds the ability to select the left or right position for the close button in the drawer component.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

FalkWolsky and others added 2 commits February 25, 2024 14:58
Display Fix for Marketplaces
Adds the ability to select the left or right position for the close button in the drawer component.
Copy link

netlify bot commented Feb 26, 2024

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 966fa27

FalkWolsky
FalkWolsky previously approved these changes Feb 26, 2024
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this amazing contribution! You even took the time to give it a styling... Very nice!

If I could ask you... We do introduce a lot of styles to the components to give it into the hand of users as good as we can that they can individualize all aspects of Components.
Maybe you could add this properties too and allow users to style the button?

@FalkWolsky FalkWolsky changed the base branch from main to dev February 26, 2024 21:29
@FalkWolsky FalkWolsky dismissed their stale review February 26, 2024 21:29

The base branch was changed.

@FalkWolsky FalkWolsky merged commit c6629a1 into lowcoder-org:dev Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants