Skip to content

nav component issue fixes, component updates in progress #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

imtananikhwa
Copy link
Contributor

@imtananikhwa imtananikhwa commented Feb 22, 2024

FEEDBACK:

Nav Component - Text-Size have to be respected, Margin and Padding too. Style for the sub-menu entries should be possible to set individually. Background Image (and its siblings) should be added
Link Component - Padding must be respected vertically correct, Border Radius must be respected
Mention Component - Text-Size have to be respected, Input field should have same height as standard input field height
Dropdown - 2 times border-radius and border-color to set, one time is enough, Border-Width have to be respected, Text-Weight have to be respected
Toggle Button - Padding must be respected horizontally correct, Border-Width have to be respected

Following changes have been made:

Nav Component:
Text size, margin and padding issue. Didn't change sub menu styling

Link Component:
Padding and border radius fixed

Mention component:
Text size issue fixed

Dropdown:
duplicate style properties removed.
Styling showing when display when label only is selected

Toggle Button:
Padding and Border width working

Circle Progress:
Circle progress style type and variable created to ensure relevant styles are shown
Styles and their control added

File Component: (fileComp.tsx)
Styles and their control added

Known Issues:

Nav component:
Padding when increased doesn't change the overall component height.

Dropdown:
styling not working when display with label only property is disabled.

Progress:
none of the border styling is working ==> will look into the antd documentation and updated type accordingly

Other:
Added "Montserrat" google font so font family property can be tested for the components.

@FalkWolsky FalkWolsky merged commit b31e606 into lowcoder-org:style-changes-imtaman Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants