nav component issue fixes, component updates in progress #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEEDBACK:
Nav Component - Text-Size have to be respected, Margin and Padding too. Style for the sub-menu entries should be possible to set individually. Background Image (and its siblings) should be added
Link Component - Padding must be respected vertically correct, Border Radius must be respected
Mention Component - Text-Size have to be respected, Input field should have same height as standard input field height
Dropdown - 2 times border-radius and border-color to set, one time is enough, Border-Width have to be respected, Text-Weight have to be respected
Toggle Button - Padding must be respected horizontally correct, Border-Width have to be respected
Following changes have been made:
Nav Component:
Text size, margin and padding issue. Didn't change sub menu styling
Link Component:
Padding and border radius fixed
Mention component:
Text size issue fixed
Dropdown:
duplicate style properties removed.
Styling showing when display when label only is selected
Toggle Button:
Padding and Border width working
Circle Progress:
Circle progress style type and variable created to ensure relevant styles are shown
Styles and their control added
File Component: (fileComp.tsx)
Styles and their control added
Known Issues:
Nav component:
Padding when increased doesn't change the overall component height.
Dropdown:
styling not working when display with label only property is disabled.
Progress:
none of the border styling is working ==> will look into the antd documentation and updated type accordingly
Other:
Added "Montserrat" google font so font family property can be tested for the components.