Skip to content

Fixed typo in javascript-query.md #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

mdpung
Copy link
Contributor

@mdpung mdpung commented Jan 22, 2024

Proposed changes

Typo in the word "parameters", missing the 'r', in the docuementation.

Types of changes

What types of changes does your code introduce to Lowcoder?
Documentation update.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

FalkWolsky and others added 2 commits January 19, 2024 19:18
Dev -> Main. Small hotfixes for 2.3.0
Typo in the word "parameters", missing the 'r'.
Copy link

netlify bot commented Jan 22, 2024

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e47d9e9

@mdpung mdpung changed the title Update javascript-query.md Fixed typo in javascript-query.md Jan 22, 2024
FalkWolsky
FalkWolsky previously approved these changes Jan 23, 2024
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!!

@FalkWolsky FalkWolsky changed the base branch from main to dev January 23, 2024 10:34
@FalkWolsky FalkWolsky dismissed their stale review January 23, 2024 10:34

The base branch was changed.

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your help and contribution!

@FalkWolsky FalkWolsky merged commit 026da8f into lowcoder-org:dev Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants