Skip to content

Add Oauth Handling For Open API Datasources #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

aq-ikhwa-tech
Copy link
Contributor

Proposed changes

  • Add handling to save auth config(from possible/available tokens) for open api datasource
  • Add handling to forward/inject access token into context when sending to node service for execution
  • Add custom handling to override auth mechanism if token received from api-service and then send to swagger-client for processing.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit e1d2094
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/659eba89a0c2e2000897956f

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! A long awaited feature. Very important. Thank you very much for your great contribution

@FalkWolsky FalkWolsky merged commit 113c768 into dev Jan 11, 2024
@FalkWolsky FalkWolsky deleted the add-oauth-handling-for-open-api-datasources branch January 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants