Skip to content

Responsive layout: Table column delete gives error #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Responsive layout: Table column delete gives error #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e34e82
fix: fix error on deleting table's column inside resp layout
raheeliftikhar5 Nov 21, 2023
edfeb4f
Merge branch 'dev' into resp-layout-table-column-delete-fix
FalkWolsky Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/packages/lowcoder/src/comps/comps/responsiveLayout/responsiveLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ class ResponsiveLayoutImplComp extends ResponsiveLayoutBaseComp implements ICont
},
} as CompAction;
}
if (value.type === "delete" && columns.length <= 1) {
const { path } = action;
if (value.type === "delete" && path[0] === 'columns' && columns.length <= 1) {
messageInstance.warning(trans("responsiveLayout.atLeastOneColumnError"));
// at least one column
return this;
Expand Down
33 changes: 0 additions & 33 deletions client/packages/lowcoder/src/pages/setting/idSource/createModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,39 +176,6 @@ function CreateModal(props: CreateModalProp) {
</div>
);
})}
{/* <Form.Item
name="clientId"
label="Client ID"
rules={[{ required: true }]}
>
<Input
placeholder={trans("idSource.formPlaceholder", {
label: 'Client ID',
})}
autoComplete="off"
/>
</Form.Item>
<Form.Item
name="clientSecret"
label={
<PasswordLabel>
<span>{"Client secret"}:</span>
<CloseEyeIcon />
</PasswordLabel>
}
rules={[{
required: true,
message: trans("idSource.formPlaceholder", {
label: 'Client secret',
})
}]}
>
<Input
type="password"
placeholder={trans("idSource.encryptedServer")}
autoComplete="off"
/>
</Form.Item> */}
</FormStyled>
</CustomModalStyled>
);
Expand Down