Skip to content

Feat/home icon #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Feat/home icon #290

merged 3 commits into from
Jul 18, 2023

Conversation

aaron1604
Copy link
Contributor

@aaron1604 aaron1604 commented Jul 18, 2023

Proposed changes

  • Changed API_PROXY_TARGET to LOWCODER_API_SERVICE_URL to maintain standard naming.
  • Added LOWCODER_NODE_SERVICE_URL to resolve data source Icon issue.
  • Added LOWCODER_CUSTOM_LOGO and LOWCODER_CUSTOM_LOGO_SQUARE, So now you can set these 2 environment variable and setup your custom logo instead of using Lowcoder logo.
  • Added LOWCODER_SHOW_BRAND. BY setting this true or false as an environment variable, you can control if you want to show logo on lowcoder or not. If you set it false, Instead of Logo, Lowcoder will display home icon.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • [ x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x ] Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • [ x ] Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@netlify
Copy link

netlify bot commented Jul 18, 2023

👷 Deploy request for classy-bombolone-94aec0 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c3e3fe5

@netlify
Copy link

netlify bot commented Jul 18, 2023

‼️ Deploy request for lowcoder-cloud rejected.

Name Link
🔨 Latest commit c3e3fe5

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are very good contributions. Thank you very much!

@aaron1604 aaron1604 merged commit 2327b72 into lowcoder-org:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants