Skip to content

[Fix] Move tab-index position to the Interaction Section for better UX #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025
Merged

[Fix] Move tab-index position to the Interaction Section for better UX #1706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/packages/lowcoder/src/comps/comps/dateComp/dateComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ const DatePickerTmpCmp = new UICompBuilder(childrenMap, (props) => {
{disabledPropertyView(children)}
{hiddenPropertyView(children)}
{showDataLoadingIndicatorsPropertyView(children)}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>
</>
)}
Expand All @@ -344,7 +345,6 @@ const DatePickerTmpCmp = new UICompBuilder(childrenMap, (props) => {
<><Section name={sectionNames.advanced}>
{timeFields(children, isMobile)}
{children.suffixIcon.propertyView({ label: trans("button.suffixIcon") })}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section></>
)}
{(useContext(EditorContext).editorModeStatus === "logic" || useContext(EditorContext).editorModeStatus === "both") && !isMobile && commonAdvanceSection(children)}
Expand Down Expand Up @@ -543,6 +543,7 @@ let DateRangeTmpCmp = (function () {
{disabledPropertyView(children)}
{hiddenPropertyView(children)}
{showDataLoadingIndicatorsPropertyView(children)}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>
</>
)}
Expand All @@ -560,7 +561,6 @@ let DateRangeTmpCmp = (function () {
<><Section name={sectionNames.advanced}>
{timeFields(children, isMobile)}
{children.suffixIcon.propertyView({ label: trans("button.suffixIcon") })}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section></>
)}
{(useContext(EditorContext).editorModeStatus === "logic" || useContext(EditorContext).editorModeStatus === "both") && commonAdvanceSection(children)}
Expand Down
4 changes: 2 additions & 2 deletions client/packages/lowcoder/src/comps/comps/dateComp/timeComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ const TimePickerTmpCmp = new UICompBuilder(childrenMap, (props) => {
{disabledPropertyView(children)}
{hiddenPropertyView(children)}
{showDataLoadingIndicatorsPropertyView(children)}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section></>
)}

Expand All @@ -266,7 +267,6 @@ const TimePickerTmpCmp = new UICompBuilder(childrenMap, (props) => {
{commonAdvanceSection(children)}
{children.use12Hours.propertyView({ label: trans("prop.use12Hours") })}
{children.suffixIcon.propertyView({ label: trans("button.suffixIcon") })}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>
)}

Expand Down Expand Up @@ -428,6 +428,7 @@ const TimeRangeTmpCmp = (function () {
{disabledPropertyView(children)}
{hiddenPropertyView(children)}
{showDataLoadingIndicatorsPropertyView(children)}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section></>
)}

Expand All @@ -444,7 +445,6 @@ const TimeRangeTmpCmp = (function () {
{commonAdvanceSection(children)}
{children.use12Hours.propertyView({ label: trans("prop.use12Hours") })}
{children.suffixIcon.propertyView({ label: trans("button.suffixIcon") })}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>
)}

Expand Down
2 changes: 1 addition & 1 deletion client/packages/lowcoder/src/comps/comps/numberInputComp/numberInputComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,7 @@ let NumberInputTmpComp = (function () {
{children.onEvent.getPropertyView()}
{disabledPropertyView(children)}
{hiddenPropertyView(children)}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>
</>
)}
Expand All @@ -458,7 +459,6 @@ let NumberInputTmpComp = (function () {
})}
{children.controls.propertyView({ label: trans("numberInput.controls") })}
{readOnlyPropertyView(children)}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>
)}

Expand Down
1 change: 0 additions & 1 deletion client/packages/lowcoder/src/comps/comps/numberInputComp/rangeSliderComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ const RangeSliderBasicComp = (function () {
tooltip: trans("rangeSlider.stepTooltip"),
})}
{children.vertical.propertyView({ label: trans("slider.vertical") })}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>

<SliderPropertyView {...children} />
Expand Down
1 change: 0 additions & 1 deletion client/packages/lowcoder/src/comps/comps/numberInputComp/sliderComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ const SliderBasicComp = (function () {
tooltip: trans("slider.stepTooltip"),
})}
{children.vertical.propertyView({ label: trans("slider.vertical") })}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section>
<FormDataPropertyView {...children} />
<SliderPropertyView {...children} />
Expand Down
1 change: 1 addition & 0 deletions client/packages/lowcoder/src/comps/comps/numberInputComp/sliderCompConstants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ const InteractionSection = memo(({ children }: { children: RecordConstructorToCo
{disabledPropertyView(children)}
{hiddenPropertyView(children)}
{showDataLoadingIndicatorsPropertyView(children as any)}
{(children as any).tabIndex?.propertyView({ label: trans("prop.tabIndex") })}
</Section>
);
});
Expand Down
2 changes: 1 addition & 1 deletion client/packages/lowcoder/src/comps/comps/selectInputComp/checkboxComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export const getStyle = (style: CheckboxStyleType) => {
}
}

.ant-checkbox-inner) {
.ant-checkbox-inner {
background-color: ${style.uncheckedBackground};
border-radius: ${style.radius};
border-color: ${style.checkedBorder};
Expand Down
5 changes: 2 additions & 3 deletions client/packages/lowcoder/src/comps/comps/selectInputComp/radioCompConstants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,9 @@ export const RadioPropertyView = (
{disabledPropertyView(children)}
{hiddenPropertyView(children)}
{showDataLoadingIndicatorsPropertyView(children as any)}
</Section>
<Section name={sectionNames.advanced}>
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
</Section></>
</Section>
</>
)}

{["layout", "both"].includes(useContext(EditorContext).editorModeStatus) && (
Expand Down
1 change: 0 additions & 1 deletion client/packages/lowcoder/src/comps/comps/textInputComp/inputComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ let InputBasicComp = new UICompBuilder(childrenMap, (props) => {
{children.prefixIcon.propertyView({ label: trans("button.prefixIcon") })}
{children.suffixIcon.propertyView({ label: trans("button.suffixIcon") })}
{children.showCount.propertyView({ label: trans("prop.showCount") })}
{children.tabIndex.propertyView({ label: trans("prop.tabIndex") })}
{allowClearPropertyView(children)}
{readOnlyPropertyView(children)}
</Section>
Expand Down
2 changes: 1 addition & 1 deletion client/packages/lowcoder/src/comps/comps/textInputComp/textInputConstants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ export const TextInputInteractionSection = (children: TextInputComp) => (
{children.onEvent.getPropertyView()}
{disabledPropertyView(children)}
{showDataLoadingIndicatorsPropertyView(children as any)}
{(children as any).tabIndex?.propertyView({ label: trans("prop.tabIndex") })}
</Section>
);

Expand Down Expand Up @@ -308,7 +309,6 @@ export function getStyle(style: InputLikeStyleType, labelStyle?: LabelStyleType)
text-decoration:${style.textDecoration};
background-color: ${style.background};
border-color: ${style.border};
// line-height: ${style.lineHeight};

&:focus,
&.ant-input-affix-wrapper-focused {
Expand Down
Loading