Skip to content

change the minimum of the slide control #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Conversation

lublak
Copy link

@lublak lublak commented May 6, 2025

Proposed changes

allows to define horizontal grid cells with size "1" which is easier to work with for imsple stack based forms

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

allows to define horizontal grid cells with size "1" which is easier to work with for imsple stack based forms
Copy link

netlify bot commented May 6, 2025

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a9af7bf

FalkWolsky
FalkWolsky previously approved these changes May 22, 2025
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

Initially, we tested the grid system and defined 8 as "sense-making minimum". But we can follow your idea too, and will just merge the changes.

@FalkWolsky FalkWolsky changed the base branch from main to dev May 22, 2025 17:43
@FalkWolsky FalkWolsky dismissed their stale review May 22, 2025 17:43

The base branch was changed.

Copy link

netlify bot commented May 22, 2025

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 18b0889

@FalkWolsky FalkWolsky merged commit c9f9dda into lowcoder-org:dev May 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants