Skip to content

Added examples for Existing Components - Demo #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

adnanqaops
Copy link
Collaborator

@adnanqaops adnanqaops commented Nov 15, 2024

Proposed changes

  1. Added "Show Searchable" property/example to Select and Multi-Select component
  2. Number Input Component : Added example for "Steps" and "Show/Hide Increment/Decrement buttons"
  3. Range Slider Component : Added example for "Vertical alignment", but it wasn't showing up on Components page.
  4. Rating Component : Fixed an issue on Rating component to show the default value of Ratings
  5. Slider Component : Added example for "Vertical alignment", but it wasn't showing up on Components page.
  6. Dropdown Component : Removed "Loading" and "Styles" examples from Dropdown component, because these were not relevant/applicable on it
  7. Date Range Component : Added examples for "Show Time" and " Show Time ( 12 hours format ) "
  8. Time Component : Added example for "Time Steps" and "Show Time ( 12 hours format )"
  9. Time Range Component : Added example for "Time Steps" and "Show Time ( 12 hours format )"

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 6d3f013
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/6736eb9a0d444d0008ce08e9
😎 Deploy Preview https://deploy-preview-1308--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adnanqaops adnanqaops marked this pull request as ready for review November 15, 2024 07:02
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a truly valuable contribution. Nothing is more powerful than a good documentation!

@FalkWolsky FalkWolsky merged commit 870a6e6 into dev Nov 15, 2024
7 checks passed
@FalkWolsky FalkWolsky deleted the doc/existing_components branch November 15, 2024 23:02
@raheeliftikhar5 raheeliftikhar5 restored the doc/existing_components branch November 18, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants