Skip to content

Update auth flow #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 7, 2024
Merged

Update auth flow #1253

merged 13 commits into from
Nov 7, 2024

Conversation

raheeliftikhar5
Copy link
Collaborator

@raheeliftikhar5 raheeliftikhar5 commented Oct 23, 2024

Proposed changes

Till now, everyone could Sign Up at a instance of Lowcoder. Also, a user needed to have a special link to reach the Login-Site of a Workspace, where an individual Auth Provider setup may have been configured.

We changed the whole flow now and only a central login form is left. Based on a selection, the user identifies the workspace he want to login there and get presented after that all possible Auth Providers for that workspace on the common central login form.

Next to it, we finally respect also the ENV LOWCODER_EMAIL_SIGNUP_ENABLED - so the Signup is not possible, if this ENV turned to false. This is a long awaited change and many of you had a lot of patience with us, till we finally made this happen. Also for us it was a longer way, as things can get fast quite complex under the hood.

However, we hope that now it will be a truly good user experience!

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@raheeliftikhar5 raheeliftikhar5 changed the title Update auth flow [WIP] Update auth flow Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit 012532f
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/672d21aedac3d600085964c7

@raheeliftikhar5 raheeliftikhar5 changed the title [WIP] Update auth flow Update auth flow Oct 24, 2024
@raheeliftikhar5 raheeliftikhar5 force-pushed the feat_auth_flow branch 2 times, most recently from b41c3ec to b968f8b Compare October 28, 2024 17:12
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are truly remarkable and of huge value for our community. We can only express our thankfulness!

@FalkWolsky FalkWolsky merged commit b21c044 into dev Nov 7, 2024
7 checks passed
@FalkWolsky FalkWolsky deleted the feat_auth_flow branch November 7, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants