-
Notifications
You must be signed in to change notification settings - Fork 245
Update auth flow #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update auth flow #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lowcoder-test canceled.
|
b41c3ec
to
b968f8b
Compare
3420dc4
to
66c9932
Compare
…om serverSettings
31e94be
to
f838d86
Compare
FalkWolsky
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are truly remarkable and of huge value for our community. We can only express our thankfulness!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Till now, everyone could Sign Up at a instance of Lowcoder. Also, a user needed to have a special link to reach the Login-Site of a Workspace, where an individual Auth Provider setup may have been configured.
We changed the whole flow now and only a central login form is left. Based on a selection, the user identifies the workspace he want to login there and get presented after that all possible Auth Providers for that workspace on the common central login form.
Next to it, we finally respect also the ENV LOWCODER_EMAIL_SIGNUP_ENABLED - so the Signup is not possible, if this ENV turned to false. This is a long awaited change and many of you had a lot of patience with us, till we finally made this happen. Also for us it was a longer way, as things can get fast quite complex under the hood.
However, we hope that now it will be a truly good user experience!
Types of changes
Checklist