Skip to content

fix issue with lastEditedAt #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
import org.springframework.util.StringUtils;

import java.time.Instant;
import java.util.Collections;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.*;
import java.util.function.Supplier;

import static com.google.common.base.Suppliers.memoize;
Expand Down Expand Up @@ -155,7 +152,9 @@ public ApplicationQuery getQueryByViewModeAndQueryId(boolean isViewMode, String
@Transient
@JsonIgnore
public Map<String, Object> getLiveApplicationDsl() {
return MapUtils.isEmpty(publishedApplicationDSL) ? editingApplicationDSL : publishedApplicationDSL;
var dsl = MapUtils.isEmpty(publishedApplicationDSL) ? editingApplicationDSL : publishedApplicationDSL;
if (dsl == null) dsl = new HashMap<>();
return dsl;
}

public String getOrganizationId() {
Expand All @@ -175,7 +174,9 @@ public int getApplicationType() {
}

public Map<String, Object> getEditingApplicationDSL() {
return editingApplicationDSL;
var dsl = editingApplicationDSL;
if (dsl == null) dsl = new HashMap<>();
return dsl;
}

public Object getLiveContainerSize() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,10 @@ public Flux<Application> findAll() {

@Override
public Mono<Boolean> updateLastEditedAt(String applicationId, Instant time, String visitorId) {
return repository.findById(applicationId)
return repository.findByIdIn(List.of(applicationId))
.filter(application -> application.getEditingUserId().equals(visitorId))
.doOnNext(application -> application.setLastEditedAt(time))
.flatMap(repository::save)
.hasElement();
.hasElements();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,8 @@ private ApplicationInfoView buildView(Application application, String role, @Nul
.publicToMarketplace(application.isPublicToMarketplace())
.agencyProfile(application.agencyProfile())
.editingUserId(application.getEditingUserId())
.lastModifyTime(application.getUpdatedAt())
.lastEditedAt(application.getLastEditedAt())
.build();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public class ApplicationInfoView {
@Nullable
private final Instant lastViewTime; // user last visit time for this app
private final Instant lastModifyTime; // app's last update time
private final Instant lastEditedAt;

private final boolean publicToAll;
private final boolean publicToMarketplace;
Expand All @@ -48,6 +49,10 @@ public long getLastModifyTime() {
return lastModifyTime == null ? 0 : lastModifyTime.toEpochMilli();
}

public long getLastEditedAt() {
return lastEditedAt == null ? 0 : lastEditedAt.toEpochMilli();
}

/**
* used by front end.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,7 @@ private ApplicationInfoView buildView(Application application, ResourceRole maxR
.applicationStatus(application.getApplicationStatus())
.lastModifyTime(application.getUpdatedAt())
.lastViewTime(lastViewTime)
.lastEditedAt(application.getLastEditedAt())
.publicToAll(application.isPublicToAll())
.publicToMarketplace(application.isPublicToMarketplace())
.agencyProfile(application.agencyProfile());
Expand Down
Loading