Skip to content

Json components height #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 8, 2024

Conversation

MenamAfzal
Copy link
Collaborator

@MenamAfzal MenamAfzal commented Aug 6, 2024

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Aug 6, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0a1c920

@MenamAfzal MenamAfzal changed the title [WIP] Json components height Json components height Aug 6, 2024
@MenamAfzal MenamAfzal marked this pull request as ready for review August 6, 2024 16:00
@MenamAfzal MenamAfzal changed the title Json components height [WIP]Json components height Aug 7, 2024
@MenamAfzal MenamAfzal marked this pull request as draft August 7, 2024 09:23
@MenamAfzal MenamAfzal changed the title [WIP]Json components height Json components height Aug 8, 2024
@MenamAfzal MenamAfzal marked this pull request as ready for review August 8, 2024 08:08
@raheeliftikhar5 raheeliftikhar5 merged commit 26eb288 into lowcoder-org:dev Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants