Skip to content

[compiler-rt] Remove duplicate MS names for chkstk symbols #80450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions compiler-rt/lib/builtins/i386/chkstk.S
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
.text
.balign 4
DEFINE_COMPILERRT_FUNCTION(_alloca) // _chkstk and _alloca are the same function
DEFINE_COMPILERRT_FUNCTION(_chkstk)
push %ecx
cmp $0x1000,%eax
lea 8(%esp),%ecx // esp before calling this routine -> ecx
Expand All @@ -35,7 +34,6 @@ DEFINE_COMPILERRT_FUNCTION(_chkstk)
push (%eax) // push return address onto the stack
sub %esp,%eax // restore the original value in eax
ret
END_COMPILERRT_FUNCTION(_chkstk)
END_COMPILERRT_FUNCTION(_alloca)

#endif // __i386__
2 changes: 0 additions & 2 deletions compiler-rt/lib/builtins/x86_64/chkstk.S
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
.text
.balign 4
DEFINE_COMPILERRT_FUNCTION(___chkstk_ms)
DEFINE_COMPILERRT_FUNCTION(__chkstk)
push %rcx
push %rax
cmp $0x1000,%rax
Expand All @@ -36,7 +35,6 @@ DEFINE_COMPILERRT_FUNCTION(__chkstk)
pop %rax
pop %rcx
ret
END_COMPILERRT_FUNCTION(__chkstk)
END_COMPILERRT_FUNCTION(___chkstk_ms)

#endif // __x86_64__