[clang-tidy] Add check for assignment or comparision operators' operand in readability-math-missing-parentheses
#141345
+28
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang-tidy Author: None (flovent) ChangesFixes false negative in #141249. Add check for math binary operators which are operands of assignment or comparision operators. Full diff: https://github.com/llvm/llvm-project/pull/141345.diff 3 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp b/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp
index 64ce94e3fc1db..d867c94242f9b 100644
--- a/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp
@@ -16,13 +16,15 @@ using namespace clang::ast_matchers;
namespace clang::tidy::readability {
void MathMissingParenthesesCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(binaryOperator(unless(hasParent(binaryOperator())),
- unless(isAssignmentOperator()),
- unless(isComparisonOperator()),
- unless(hasAnyOperatorName("&&", "||")),
- hasDescendant(binaryOperator()))
- .bind("binOp"),
- this);
+ Finder->addMatcher(
+ binaryOperator(
+ unless(hasParent(binaryOperator(unless(isAssignmentOperator()),
+ unless(isComparisonOperator())))),
+ unless(isAssignmentOperator()), unless(isComparisonOperator()),
+ unless(hasAnyOperatorName("&&", "||")),
+ hasDescendant(binaryOperator()))
+ .bind("binOp"),
+ this);
}
static int getPrecedence(const BinaryOperator *BinOp) {
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 8032f0d23f494..a7530a236e9ec 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -176,6 +176,11 @@ Changes in existing checks
<clang-tidy/checks/concurrency/mt-unsafe>` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`readability-math-missing-parentheses
+ <clang-tidy/checks/readability/math-missing-parentheses>` check by fixing
+ false negatives where math expressions are the operand of assignment operators
+ or comparison operators.
+
- Improved :doc:`misc-const-correctness
<clang-tidy/checks/misc/const-correctness>` check by adding the option
`AllowedTypes`, that excludes specified types from const-correctness
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp
index 80d2bc304bb5b..5c10ed59178d8 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp
@@ -157,3 +157,17 @@ namespace PR92516 {
for (j = i + 1, 2; j < 1; ++j) {}
}
}
+
+namespace PR141249 {
+ void AssignAsParentBinOp(int* netChange, int* nums, int k, int i) {
+ //CHECK-MESSAGES: :[[@LINE+1]]:30: warning: '-' has higher precedence than '^'; add parentheses to explicitly specify the order of operations [readability-math-missing-parentheses]
+ netChange[i] = nums[i] ^ k - nums[i];
+ }
+}
+
+void CompareAsParentBinOp(int b) {
+ //CHECK-MESSAGES: :[[@LINE+1]]:12: warning: '*' has higher precedence than '-'; add parentheses to explicitly specify the order of operations [readability-math-missing-parentheses]
+ if (b == 1 * 2 - 3) {
+
+ }
+}
|
|
@llvm/pr-subscribers-clang-tools-extra Author: None (flovent) ChangesFixes false negative in #141249. Add check for math binary operators which are operands of assignment or comparision operators. Full diff: https://github.com/llvm/llvm-project/pull/141345.diff 3 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp b/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp
index 64ce94e3fc1db..d867c94242f9b 100644
--- a/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/MathMissingParenthesesCheck.cpp
@@ -16,13 +16,15 @@ using namespace clang::ast_matchers;
namespace clang::tidy::readability {
void MathMissingParenthesesCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(binaryOperator(unless(hasParent(binaryOperator())),
- unless(isAssignmentOperator()),
- unless(isComparisonOperator()),
- unless(hasAnyOperatorName("&&", "||")),
- hasDescendant(binaryOperator()))
- .bind("binOp"),
- this);
+ Finder->addMatcher(
+ binaryOperator(
+ unless(hasParent(binaryOperator(unless(isAssignmentOperator()),
+ unless(isComparisonOperator())))),
+ unless(isAssignmentOperator()), unless(isComparisonOperator()),
+ unless(hasAnyOperatorName("&&", "||")),
+ hasDescendant(binaryOperator()))
+ .bind("binOp"),
+ this);
}
static int getPrecedence(const BinaryOperator *BinOp) {
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 8032f0d23f494..a7530a236e9ec 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -176,6 +176,11 @@ Changes in existing checks
<clang-tidy/checks/concurrency/mt-unsafe>` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`readability-math-missing-parentheses
+ <clang-tidy/checks/readability/math-missing-parentheses>` check by fixing
+ false negatives where math expressions are the operand of assignment operators
+ or comparison operators.
+
- Improved :doc:`misc-const-correctness
<clang-tidy/checks/misc/const-correctness>` check by adding the option
`AllowedTypes`, that excludes specified types from const-correctness
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp
index 80d2bc304bb5b..5c10ed59178d8 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/readability/math-missing-parentheses.cpp
@@ -157,3 +157,17 @@ namespace PR92516 {
for (j = i + 1, 2; j < 1; ++j) {}
}
}
+
+namespace PR141249 {
+ void AssignAsParentBinOp(int* netChange, int* nums, int k, int i) {
+ //CHECK-MESSAGES: :[[@LINE+1]]:30: warning: '-' has higher precedence than '^'; add parentheses to explicitly specify the order of operations [readability-math-missing-parentheses]
+ netChange[i] = nums[i] ^ k - nums[i];
+ }
+}
+
+void CompareAsParentBinOp(int b) {
+ //CHECK-MESSAGES: :[[@LINE+1]]:12: warning: '*' has higher precedence than '-'; add parentheses to explicitly specify the order of operations [readability-math-missing-parentheses]
+ if (b == 1 * 2 - 3) {
+
+ }
+}
|
EugeneZelenko
requested review from
PiotrZSL,
carlosgalvezp,
vbvictor and
HerrCai0907
flovent
force-pushed
the
clang-tidy-issue-141249
branch
from
855cef0 to
7d4d9e1
Compare
PiotrZSL
approved these changes
May 25, 2025
|
Please write "Closes #141249 (issue no)" at the end of PR description when fixing an issue. It will automatically link the issue, which will be closed on merge. |
|
Please rebase from |
…nd in `readability-math-missing-parentheses`
flovent
force-pushed
the
clang-tidy-issue-141249
branch
from
7d4d9e1 to
8ac2893
Compare
|
Rebased and changed PR description for linking to resolved issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false negative in #141249.
Add check for math binary operators which are operands of assignment or comparision operators.
Closes #141249.