Skip to content

[OptTable] Fix typo VALUE => VALUES (NFCI) #121523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlexMaclean
Copy link
Member

While VALUES is not actually used by LLVM_MAKE_OPT_ID_WITH_ID_PREFIX threading the correct value through is clearer and avoids the potential for strange bugs if this ever changes.

@AlexMaclean AlexMaclean requested a review from chandlerc January 2, 2025 21:50
@AlexMaclean AlexMaclean self-assigned this Jan 2, 2025
@chandlerc
Copy link
Member

I'm not the right reviewer here these days...

@chandlerc chandlerc removed their request for review January 8, 2025 00:21
@AlexMaclean AlexMaclean requested a review from jurahul January 8, 2025 00:50
@AlexMaclean AlexMaclean merged commit e540546 into llvm:main Jan 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants