A Hodge-Podge of Fixes and Features #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// - returns: A representation of the newly created inline assembly | ||
| /// expression. | ||
| public func buildInlineAssembly(_ asm: String, type: FunctionType, constraints: String = "", hasSideEffects: Bool = true, needsAlignedStack: Bool = true) -> IRValue { |
There was a problem hiding this comment.
Is there a URL we can point to for more information? Or is this documentation already better than the existing LLVM doc...?
There was a problem hiding this comment.
This kind of is LLVM's docs on this. Paraphrased and updated a bit with references to external stuff.
|
LGTM! |
harlanhaskins
approved these changes
Sep 6, 2017
Use the derived ==. Providing our own causes a cyclic dependency on the ordering -> LLVM map which causes crashes on recursive initial accesses to the dictionary.
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threadLocalModetothreadLocalModel- LLVM is wrong, not us.Switchinstructions to get the default block(Support for module-level ASM is tricky without a better C API)