Skip to content

Give Sections a Relocation iterator #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2017
Merged

Give Sections a Relocation iterator #96

merged 1 commit into from
Aug 30, 2017

Conversation

CodaFi
Copy link
Member

@CodaFi CodaFi commented Aug 30, 2017

Fixup ObjectFile by

  • Extending the documentation
  • Restoring the deinitializers (should have definitely done this earlier)
  • Adding a way to iterate over the symbol relocations in a Section of an Object File

harlanhaskins
harlanhaskins approved these changes Aug 30, 2017
View reviewed changes
Copy link
Member

@harlanhaskins harlanhaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodaFi
Copy link
Member Author

CodaFi commented Aug 30, 2017

⛵

@CodaFi CodaFi merged commit 394cf67 into llvm-swift:master Aug 30, 2017
@CodaFi CodaFi deleted the objection! branch August 30, 2017 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @harlanhaskins