Deprecate BasicBlock.delete() with a stern warning #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing blocks from the CFG is not as easy as it might appear at first. Incorrect deletion of a block can cause dangling references to appear in the function which show up as bad accesses when deallocation of the parent function occurs. The safest way to remove a Basic Block is to first make sure that it is freshly inserted. Next, walk its instructions and, in turn, their uses and overwrite those uses with undef. Next, remove those instructions from the basic block one by one. Finally, call removeFromParent(). Do not attempt to delete() the block, the containing function will handle that when it goes to destroy the module.
harlanhaskins
approved these changes
Mar 29, 2017
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
BasicBlock.delete()and marks it for removal at a later date when we figure this out. I'm going to submit a corresponding pull request to Trill to resolve the issues we've been seeing related to this API.