Update README #80
Merged
Update README #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
requested changes
Mar 28, 2017
README.md
Outdated
| let builder = IRBuilder(module: module) | ||
|
|
||
| let main = builder.addFunction( | ||
| name: "main", |
README.md
Outdated
| let main = builder.addFunction( | ||
| name: "main", | ||
| type: FunctionType(argTypes: [], | ||
| returnType: VoidType()) |
README.md
Outdated
| Notice that the value of `retVal` depends on the path the flow of control takes through this program, so we must emit a Phi node to properly initialize it: | ||
|
|
||
| ```swift | ||
| let function = builder.addFunction("calculateFibs", type: FunctionType(argTypes: [IntType.int1], returnType: FloatType.double)) |
There was a problem hiding this comment.
Let's align these parameters
README.md
Outdated
| Notice that the value of `retVal` depends on the path the flow of control takes through this program, so we must emit a Phi node to properly initialize it: | ||
|
|
||
| ```swift | ||
| let function = builder.addFunction("calculateFibs", type: FunctionType(argTypes: [IntType.int1], returnType: FloatType.double)) |
There was a problem hiding this comment.
Should we explain that booleans are int1?
There was a problem hiding this comment.
I did want to add a section on types originally. I'll see what I can do.
|
|
||
| ```swift | ||
| // Setup the JIT | ||
| let jit = try! JIT(module: module, machine: TargetMachine()) |
There was a problem hiding this comment.
Pretty sure the machine is defaulted, no?
|
Looks amazing modulo nitpicks! |
harlanhaskins
approved these changes
Mar 28, 2017
README.md
Outdated
| Notice that the value of `retVal` depends on the path the flow of control takes through this program, so we must emit a PHI node to properly initialize it: | ||
|
|
||
| ```swift | ||
| let function = builder.addFunction("calculateFibs", type: FunctionType(argTypes: [IntType.int1], returnType: FloatType.double)) |
There was a problem hiding this comment.
Still maybe align these parameters?
CodaFi
force-pushed
the
readme-and-weep
branch
2 times, most recently
from
53e7662 to
ff34558
Compare
|
New section on types |
harlanhaskins
approved these changes
Mar 28, 2017
|
🚢 🇮🇹 |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.