Constants #54
Constants #54
Conversation
CodaFi
force-pushed
the
constantly-constituted-constrainted-constructions
branch
2 times, most recently
from
4f4a066 to
bbe4b40
Compare
|
Done. @harlanhaskins? |
| } | ||
|
|
||
| public static func +(lhs: Constant, rhs: Constant) -> Constant { | ||
| precondition(lhs.repr == rhs.repr, "Mixed-representation constant operations are disallowed") |
There was a problem hiding this comment.
I wonder if we could bubble this up to type-level? Make Representation an internal protocol with three members and make Constant generic. Then + wouldn't apply between Constant<Unsigned> and Constant<Floating>
There was a problem hiding this comment.
All these asserts are sanity checks. All operations are homogenous, the type is generic.
| /// behavior of the resulting constant value. | ||
| /// | ||
| /// - returns: A constant value representing the negation of the given constant. | ||
| public static func neg(_ lhs: Constant<Signed>, overflowBehavior: OverflowBehavior = .default) -> Constant<Signed> { |
There was a problem hiding this comment.
Should these be spelled out?
There was a problem hiding this comment.
multiply and subtract are out?
There was a problem hiding this comment.
Sorry, back to my computer. I'm actually not sure why the spelled-out versions need to exist. But I think maybe they should be fully-spelled-out.
There was a problem hiding this comment.
They need to exist because overflowBehavior.
There was a problem hiding this comment.
Right! Then I think they should be spelled out. 👍
CodaFi
force-pushed
the
constantly-constituted-constrainted-constructions
branch
from
c3d8c85 to
fa9c151
Compare
|
⛵️ |
Introduces a new typesafe API for integral constants. The intent is to make it as natural as possible to interact with constants, so they come equipped with a DSL that allows Swift's native arithmetic operators to be applied in place of LLVM constant expression calls. Tests are included to make sure const-operand-having instructions really are const-folded away.