Remove LLVMAddInternalizePassWithMustPreservePredicate from shims #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
Feb 14, 2021
|
CI failure due to Travis needing updated to install LLVM 11 instead of 9 |
|
I believe this is good to go. Feel free to merge when convenient. (I am unable.) |
This was referenced Feb 16, 2021
Closed
This is already provided by llvm-c in IPO.h per https://reviews.llvm.org/D62456
matthewseaman
force-pushed
the
dupe-symbol
branch
from
455685d to
11a963b
Compare
|
CI failures are now expected and fixed by #227. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #222.
This symbol is already provided by
llvm-cinIPO.hper this addition. @CodaFi got this merged into upstream LLVM two years ago with the exact same implementation (see here and here and compare with removed definition), so it is unclear to me why this just now broke.