Vector support #104
Merged
Vector support #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
reviewed
Sep 18, 2017
Sources/LLVM/IRType.swift
Outdated
| @@ -36,6 +36,16 @@ public extension IRType { | |||
| } | |||
| } | |||
|
|
|||
| extension IRType { | |||
| internal func lowerFromVector() -> IRType { | |||
There was a problem hiding this comment.
I don't anticipate this being used outside of the IRBuilder, so a private free function would work.
There was a problem hiding this comment.
Sure, I head home in a bit and then I can update the PR.
|
Last thing: Could you add file check tests for the vector instructions? |
|
Eh, I've got tests. ⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a local copy of #103 with updates