Initial ORCJIT Bindings #102
Conversation
| /// - ctx: A void pointer pointing to a retained ORCJIT instance. | ||
| /// - Returns: A callable address of a compiled function, or 0 if no such | ||
| /// function was found. | ||
| func orcjitSymbolResolver(symbol: UnsafePointer<Int8>?, |
There was a problem hiding this comment.
Nope, it’s only used as a shim passed into the Orc bindings. It calls into the public symbol resolvers.
|
From a cursory glance, this is missing
|
| return jit.resolver.address(of: String(cString: cString), in: jit) ?? 0 | ||
| } | ||
|
|
||
| public class ORCJIT { |
There was a problem hiding this comment.
This should be documented like mad (and at the top of this file).
|
|
||
| private var sharedObjectBuffers = [LLVMSharedObjectBufferRef]() | ||
|
|
||
| public enum Error: Swift.Error { |
| /// The strategy that ORCJIT should use to compile a specific module. | ||
| public enum CompilationStrategy { | ||
| /// The IR will be compiled lazily, one function at a time. | ||
| case lazy |
There was a problem hiding this comment.
The JIT provides LLVMOrcCreateLazyCompileCallback to be fired when it resolves symbols. We could wrap this and let the user pass us a block.
| /// - Returns: `nil` if the symbol could not be found, otherwise the opaque | ||
| /// address of a C function pointer that can be called to execute | ||
| /// the compiled code. | ||
| func address(of symbol: String, in jit: ORCJIT) -> UInt64? |
There was a problem hiding this comment.
Can we provide a public typealias for LLVMOrcTargetAddress instead of using UInt64?
|
|
||
| /// Runs a series of symbol resolvers in order, stopping when the first resolver | ||
| /// finds a valid symbol. | ||
| public struct CompoundSymbolResolver: SymbolResolver { |
There was a problem hiding this comment.
@CodaFi should compound resolvers just...be the default? i.e. should ORCJIT always keep a chain of resolvers and run them, defaulting to the simple resolver?
There was a problem hiding this comment.
Ooh, neat. Sure, sounds good. Then symbol resolution is a fold with ??.
|
Subsumed by #158 |
This patch provides an initial set of ORCJIT bindings. They're incomplete, and the ORC API will evolve past this in the near future.