Skip to content

remove escape logic for passwords (do not merge until sufficient testing on bookstack PR 140) #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

remove escape logic for passwords (do not merge until sufficient testing on bookstack PR 140) #109

wants to merge 4 commits into from

Conversation

drizuid
Copy link
Member

@drizuid drizuid commented Oct 10, 2022

see linuxserver/docker-bookstack#140
do not merge until testing on above is completed

@drizuid
remove escape logic for passwords
05ac720 
if linuxserver/docker-bookstack#140 works, we should replicate.
do not merge until we consider the above PR to be sufficiently tested (but before end of month so i can get a tshirt ;)
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/index.html
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/shellcheck-result.xml

@drizuid drizuid changed the title remove escape logic for passwords remove escape logic for passwords (do not merge until sufficient testing on bookstack PR 140) Oct 10, 2022
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/index.html
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/shellcheck-result.xml

2 similar comments
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/index.html
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/shellcheck-result.xml

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/index.html
https://ci-tests.linuxserver.io/lspipepr/mariadb/10.5.17-r0-pkg-ffca7c40-pr-109/shellcheck-result.xml

thespad added a commit that referenced this pull request Oct 11, 2022
@thespad
Update string escape logic to match #109
97f741d
@thespad thespad mentioned this pull request Oct 11, 2022
Merged
1 task
@thespad thespad closed this in #110 Oct 11, 2022
@drizuid drizuid deleted the remove-escape-logic branch October 17, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemchik nemchik nemchik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drizuid @LinuxServer-CI @nemchik