remove curl install/purge from Dockerfile #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curl is installed by baseimage-alpine already, we were then installing it as a build dependency and purging it. it wasn't actually being purged, but regardless, curl is required for our remote_sql actions in 40-initialise-db
|
I am a bot, here are the test results for this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already install curl in baseimage-alpine. we were then installing into the container itself as a build-dependency and then purging it. Had this actually been working, it would've broken our remote-sql function in 40-initialise-db, but fortunately it appear the purge did not actually remove curl. This just removed the superfluous lines from the dockerfiles with no functional change.