Resolving php-local.ini mangling #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
1 similar comment
CHBMB
reviewed
Sep 19, 2020
|
LGTM |
|
This should resolve #64 |
alex-phillips
approved these changes
Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates grep to not be both regex & string pattern match to prevent mis-matching of line, also changes "MB" to PHP standard "M"
Benefits of this PR and context:
If this isn't fixed, all posts & logins seem to fail
It also leads to duplication infinitely every restart
How Has This Been Tested?
Ran the scripts local in the container to verify functionality in the container.
Source / References:
https://discordapp.com/channels/354974912613449730/506925392603512839/756980418795798558