fix substitution of APP_URL when provided #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
added a commit
to klutchell/balena-bookstack
that referenced
this pull request
Aug 18, 2020
klutchell
added a commit
to klutchell/balena-bookstack
that referenced
this pull request
Dec 3, 2020
linuxserver/docker-bookstack#62 Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We welcome all PR’s though this doesn’t guarantee it will be accepted.
Description:
Looking at the following line, I can see why
APP_URLis not being applied in/config/www/.envThis substitution is expecting
# APP_URLbut the example env file doesn't include a space:#APP_URL.The workaround is to manually edit your
/config/www/.envfile and avoid providing environment variables that would cause it to be overwritten.Benefits of this PR and context:
Fixes one of the symptoms described in #58
How Has This Been Tested?
I tested the new sed string from the command line, before copying the patched
50-configinto the existing v0.29.3-ls99 image.klutchell/balena-bookstack@703a0eb
Source / References:
#58
klutchell/balena-bookstack@703a0eb