Skip to content

Symlink all logs to avoid defer error on new install #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Conversation

thespad
Copy link
Member

@thespad thespad commented Nov 24, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Closes #194

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team November 24, 2023 13:54
@thespad thespad self-assigned this Nov 24, 2023
Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be moved out to /config/logs/bookstack/ (or something similar) so that logs are no longer exposed to the web by nginx?

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.10.4-pkg-14e04100-dev-7759d52c2503e0357cc2a042f3441fb465e8120a-pr-196/index.html
https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.10.4-pkg-14e04100-dev-7759d52c2503e0357cc2a042f3441fb465e8120a-pr-196/shellcheck-result.xml

Tag Passed
amd64-v23.10.4-pkg-14e04100-dev-7759d52c2503e0357cc2a042f3441fb465e8120a-pr-196
arm64v8-v23.10.4-pkg-14e04100-dev-7759d52c2503e0357cc2a042f3441fb465e8120a-pr-196

@thespad
Copy link
Member Author

thespad commented Nov 24, 2023

Done logs and backups

@thespad thespad requested a review from nemchik November 24, 2023 14:11
@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.10.4-pkg-14e04100-dev-78d685a31f47de8708c037d76c89e4cf7856c734-pr-196/index.html
https://ci-tests.linuxserver.io/lspipepr/bookstack/v23.10.4-pkg-14e04100-dev-78d685a31f47de8708c037d76c89e4cf7856c734-pr-196/shellcheck-result.xml

Tag Passed
amd64-v23.10.4-pkg-14e04100-dev-78d685a31f47de8708c037d76c89e4cf7856c734-pr-196
arm64v8-v23.10.4-pkg-14e04100-dev-78d685a31f47de8708c037d76c89e4cf7856c734-pr-196

@thespad thespad merged commit 586c3d8 into master Nov 25, 2023
@thespad thespad deleted the init-fix branch November 25, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Error at container setup while chown-ing laravel.log
3 participants