Update password restriction matching to db image manual #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per linuxserver/mariadb/, the required DATABASE_PASSWORD must > 4
This reverts commit b270eaf.
|
I am a bot, here are the test results for this PR:
|
nemchik
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update README to match the password requirement with dependency. Per mariadb image, the required DATABASE_PASSWORD must be greater than 4 characters.
Benefits of this PR and context:
New user who sets password less than 4 char will cause error similar to database connection issue where previous issues are all arguing DB_PASS or DB_PASSWORD which is not the solution here.
In short, it is extremely difficult to troubleshoot this error. Eventually, I decided to RTFM for one layer up which discovered the solution. This update to README should help preventing future user to pull their hair out.
** PR rule says don't PR for README typo. But this is manual content change. :)
How Has This Been Tested?
Test: setting longer password worked and short password does not.
Hardware: Raspberry PI 4B.
OS: Raspberry PI OS lite, arm64/v8
Source / References:
https://github.com/linuxserver/docker-mariadb#parameters