Added php81-iconv as an installed php extension #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding since the iconv php extension is a requirement for BookStack that has previously been polyfilled but is now needed as an extension. Related to #162
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
1 task
|
I am a bot, here are the test results for this PR: |
aptalca
approved these changes
Mar 2, 2023
|
I am a bot, here are the test results for this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the
iconvPHP extension to the build scripts since the iconv php extension is a requirement for BookStack that has previously been poly-filled but is now needed as an extension.See #162 for more detail.
Benefits of this PR and context:
This adds a required extension that's needed in certain features of BookStack, such as QR code generation for TOTP MFA.
How Has This Been Tested?
I build a fresh image for the modified files, then used that in a compose setup to check the image worked, at that the error produced from the lack of the
iconvextension no longer shows.I also checked the build log to ensure the
iconextension is no longer uninstalled in the build process, like it was before.This was on an x64 Fedora Linux 37 system.
I did not test the arm image(s) specifically.
Source / References:
#162