Skip to content

Remove simple outer arcs #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

valentinewallace
Copy link
Contributor

This isn't strictly necessary but it made the sample a bit nicer

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #816 (ce505fa) into main (e77b160) will decrease coverage by 0.31%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   91.04%   90.73%   -0.32%     
==========================================
  Files          48       48              
  Lines       25480    25642     +162     
==========================================
+ Hits        23199    23266      +67     
- Misses       2281     2376      +95     
Impacted Files Coverage Δ
lightning-block-sync/src/init.rs 93.56% <ø> (ø)
lightning-net-tokio/src/lib.rs 76.70% <ø> (ø)
lightning/src/ln/peer_handler.rs 44.82% <0.00%> (-4.90%) ⬇️
lightning/src/util/macro_logger.rs 88.33% <ø> (ø)
lightning/src/util/ser.rs 90.90% <0.00%> (+0.29%) ⬆️
lightning/src/chain/keysinterface.rs 93.15% <90.00%> (-0.21%) ⬇️
lightning-persister/src/lib.rs 92.52% <92.30%> (+0.29%) ⬆️
lightning/src/chain/channelmonitor.rs 95.52% <94.81%> (-0.16%) ⬇️
lightning-persister/src/util.rs 95.77% <100.00%> (-0.06%) ⬇️
lightning/src/chain/chainmonitor.rs 94.20% <100.00%> (+0.08%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77b160...a2d9fca. Read the comment docs.

@TheBlueMatt TheBlueMatt added this to the 0.0.13 milestone Mar 2, 2021
Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ACK a2d9fca

@TheBlueMatt TheBlueMatt merged commit 7caadd4 into lightningdevkit:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants