Implement std::error::Error for SocketParseError #3816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SocketParseError does not implement std Error which means it can't be used in standard ways like combining ? and anyhow. This commit implements std::error::Error for SocketParseError
|
I've assigned @TheBlueMatt as a reviewer! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3816 +/- ##
==========================================
+ Coverage 89.73% 89.75% +0.01%
==========================================
Files 159 159
Lines 128910 128910
Branches 128910 128910
==========================================
+ Hits 115676 115698 +22
+ Misses 10536 10511 -25
- Partials 2698 2701 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hide the std::error::Error for SocketAddressParseError implementation behind the "std" feature since it relies on the standard library.
|
🔔 1st Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketParseError does not implement std Error which means it can't be used in standard ways like combining ? and anyhow. This is problematic since it's a public interface and being able to use anyhow on public errors is nice.
This commit implements std::error::Error for SocketParseError