Convert file-level rustfmt skip to fn level skips #3809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! I see this is a draft PR. |
joostjager
force-pushed
the
rustfmt-skip-all
branch
from
9874e55 to
69a9581
Compare
They refer to other files and make rustfmt want to search for those. This is problematic with the skip-insertion script.
joostjager
force-pushed
the
rustfmt-skip-all
branch
2 times, most recently
from
a88062e to
16025f2
Compare
|
As discussed in sync meet, I will try to extend the script to ignore rustfmt changes that only affect the function signature. |
Those two directives don't seem to work together properly and make the build fail.
joostjager
force-pushed
the
rustfmt-skip-all
branch
from
16025f2 to
9ff8996
Compare
|
Pushed fix up commit to ignore sig changes. Modest reduction in skips, with a few edge cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the approach proposed in #3767 to the full repository. The change set is automatically generated using a script. The script omits skip directives when they would not impact formatting (code already rustfmt-compliant).
I've fixed various problems with the script, and it may be that there are a few edge cases left that should have had a skip directive. There could also be a few redundant ones. I think we can live with that.