Add MAX_FUNDING_SATOSHIS constant.
#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like the constant definition belongs in channel.rs with the rest of the constants at the top, but looks good either way.
…On June 30, 2018 2:46:59 PM UTC, Jean Pierre Dudey ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#38
-- Commit Summary --
* Add `MAX_FUNDING_SATOSHIS` constant.
-- File Changes --
M src/ln/channel.rs (7)
M src/ln/msgs.rs (10)
-- Patch Links --
https://github.com/rust-bitcoin/rust-lightning/pull/38.patch
https://github.com/rust-bitcoin/rust-lightning/pull/38.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#38
|
jeandudey
commented
Jun 30, 2018
src/ln/channel.rs
Outdated
| return Err(HandleError{err: "funding value > 2^24", msg: Some(msgs::ErrorAction::DisconnectPeer{})}); | ||
| } | ||
| if msg.funding_satoshis > 21000000 * 100000000 { |
There was a problem hiding this comment.
I removed this condition because I thought it never was going to be true because MAX_FUNDING_SATOSHIS should never be more high than 2,1x10^15, the test I added checks that.
jeandudey
force-pushed
the
max-funding-satoshis
branch
from
5d6c8d6 to
4bd2555
Compare
|
@TheBlueMatt Done 👍 |
This constants defines the maximum value of `open_channel.funding_satoshis`, currently it's defined to be 2^24 according to the BOLT lightningdevkit#2 specification. Also a test was added to check that the constant is never over 2,1x10^15 (maximum satoshis in bitcoin) if modified. Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
jeandudey
force-pushed
the
max-funding-satoshis
branch
from
4bd2555 to
6707db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.