Run clippy fix

[douglaz]

Result of running:

cargo clippy --fix -F futures -- -Aclippy::erasing_op -Aclippy::never_loop -Aclippy::if_same_then_else -Dclippy::try_err -Aclippy::iter_kv_map

Plus some manual formatting fixes.

In my experience clippy --fix always improves the code so I always run it before any pull request. The only issue is when it tries to introduce new features beyond the MSRV.

I hope the changes are within the directives given in #724 (comment)

[codecov-commenter]

Codecov Report

Patch coverage: 96.77% and project coverage change: +0.07 🎉

Comparison is base (b5e5435) 87.25% compared to head (05c9a0c) 87.32%.

❗ Current head 05c9a0c differs from pull request most recent head 6c348de. Consider uploading reports for the commit 6c348de to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
+ Coverage   87.25%   87.32%   +0.07%     
==========================================
  Files         100      101       +1     
  Lines       44480    44350     -130     
  Branches    44480    44350     -130     
==========================================
- Hits        38810    38728      -82     
+ Misses       5670     5622      -48     

Impacted Files	Coverage Δ
lightning-block-sync/src/poll.rs	82.35% <ø> (+0.95%)	⬆️
lightning-invoice/src/payment.rs	76.53% <50.00%> (+0.77%)	⬆️
lightning-background-processor/src/lib.rs	81.31% <80.00%> (-0.58%)	⬇️
lightning-block-sync/src/init.rs	87.79% <100.00%> (ø)
lightning-block-sync/src/lib.rs	87.31% <100.00%> (ø)
lightning-block-sync/src/test_utils.rs	79.19% <100.00%> (+0.28%)	⬆️
lightning-invoice/src/de.rs	85.00% <100.00%> (+0.28%)	⬆️
lightning-invoice/src/lib.rs	70.67% <100.00%> (+0.48%)	⬆️
lightning-invoice/src/ser.rs	80.34% <100.00%> (ø)
lightning-invoice/src/utils.rs	96.14% <100.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dunxen]

Thanks! Concept ACK.
Will give full review in the morning. :)

[dunxen]

LGTM. These are all fair improvements. A big plus for it catching some unnecessary clones.

[dunxen]

I think if we're only looking at a small set of ignores then it seems palatable to automate clippy checks with the MSRV in GH actions. I am for doing that.

[tnull]

Generally looks good, some nits/comments.

[tnull]

nit: Can now move the next line up.

[douglaz]

I think this is still consistent with the style of the test, will leave it as is

[douglaz]

Added -Dclippy::separated_literal_suffix plus minor formatting change. Also run against current main.

[douglaz]

Fixed conflict because of new commit

[TheBlueMatt]

Thanks! Basically LGTM.

[tnull]

LGTM, feel free to squash commits from my side.

[TheBlueMatt]

Total diff LGTM, thanks! Can you squash down the commits so that later commits aren't tweaking things done in the previous commits? Then I think we can land.

[douglaz]

Squashed into one commit without further changes